[Webkit-unassigned] [Bug 180978] Deadlock in GStreamer video sink during shutdown

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 9 05:50:59 PST 2018


--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
It happens when accelerated compositing is disabled, that's the case I was debugging and which this patch is fixing.

I only touched that other case for completeness to ensure that nothing is ever waiting on the condition variable during shutdown, no matter which code path is taken.

Why is the cancelled boolean unneeded in your opinion? One potential problem here is that the condition variable is signalled (due to cancelling) before waiting happens, and then it would be waiting forever if we didn't have another boolean flag that can be checked before waiting to decide whether we have to wait or should not wait because nothing is ever going to wake us up again.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180109/3e7a9f97/attachment-0001.html>

More information about the webkit-unassigned mailing list