[Webkit-unassigned] [Bug 182610] [MIPS] JSC needs to be built with -latomic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182610

--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
(In reply to Adrian Perez from comment #3)
> Comment on attachment 333412 [details]
> Patch
> 
> In Source/WebKit/CMakeLists.txt, after line 780, there's a check
> that tries to compile a snippet which uses “std::atomic<int64_t>”
> and determines whether using libatomic is needed or not. Instead
> of unconditionally adding the library as your patch does, could
> you please change the CMake code there so it adds it conditionally?
> 
> The resulting snippet patch should be something like:
> 
>         if (ATOMIC_INT64_REQUIRES_LIBATOMIC)
>             list(APPEND WebKit_LIBRARIES atomic)
>    +        list(APPEND JavaScriptCore_LIBRARIES atomic)
>         endif ()
> 
> Thanks!

Correction: This is in the CMakeLists.txt for *WebKit*, so it would
be better to move the check to one of the top-level CMakeLists.txt
and then in Source/JavaScriptCore/CMakeLists.txt append the library
conditionally to the list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180208/4b561c4f/attachment.html>