[Webkit-unassigned] [Bug 182610] [MIPS] JSC needs to be built with -latomic

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 8 13:02:07 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182610

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 333412
  --> https://bugs.webkit.org/attachment.cgi?id=333412
Patch

In Source/WebKit/CMakeLists.txt, after line 780, there's a check
that tries to compile a snippet which uses “std::atomic<int64_t>”
and determines whether using libatomic is needed or not. Instead
of unconditionally adding the library as your patch does, could
you please change the CMake code there so it adds it conditionally?

The resulting snippet patch should be something like:

        if (ATOMIC_INT64_REQUIRES_LIBATOMIC)
            list(APPEND WebKit_LIBRARIES atomic)
   +        list(APPEND JavaScriptCore_LIBRARIES atomic)
        endif ()

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180208/98c82aa2/attachment.html>


More information about the webkit-unassigned mailing list