[Webkit-unassigned] [Bug 182427] Add a way to check if a host is an IP address

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182427

--- Comment #29 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #28)
> Comment on attachment 333159 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333159&action=review
> 
> > Source/WebCore/platform/mac/URLMac.mm:85
> > +bool URL::hostIsIPAddress(const String& host)
> > +{
> > +    return [host _web_looksLikeIPAddress];
> > +}
> 
> There's also a semantic problem here, in that you're implementing an "is"
> function in terms of a "looks like" function.

Then we would allow the ipv4 addresses in the forms we don't want to accept. I guess we don't want to accept them when loading a URL either, so we would need to add an option to URLParser anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180206/93872d5a/attachment.html>