[Webkit-unassigned] [Bug 182427] Add a way to check if a host is an IP address

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 6 06:04:10 PST 2018


--- Comment #28 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 333159
  --> https://bugs.webkit.org/attachment.cgi?id=333159
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=333159&action=review

> Source/WebCore/platform/mac/URLMac.mm:85
> +bool URL::hostIsIPAddress(const String& host)
> +{
> +    return [host _web_looksLikeIPAddress];
> +}

There's also a semantic problem here, in that you're implementing an "is" function in terms of a "looks like" function.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180206/ba4bb7b0/attachment.html>

More information about the webkit-unassigned mailing list