[Webkit-unassigned] [Bug 182363] WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 2 15:02:36 PST 2018


--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332973
  --> https://bugs.webkit.org/attachment.cgi?id=332973
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=332973&action=review

>>> Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:198
>>> +        return { startURL, "./" };
>> Hm... I would have preferred to have a helper function like you did earlier.
> I'm open to adding back a helper function. How does `void defaultScopeURL(const URL& startURL)` sound?

Sure that sounds good. Alternatively, you could just compute it once at the top of the function
as defaultScopeURL local variable since this isn't a perf sensitive code.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180202/c3662090/attachment.html>

More information about the webkit-unassigned mailing list