[Webkit-unassigned] [Bug 182363] WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 2 14:39:24 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182363

--- Comment #7 from David Quesada <david_quesada at apple.com> ---
(In reply to Ryosuke Niwa from comment #6)
> Comment on attachment 332973 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332973&action=review
> 
> > Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:198
> > -        return { };
> > +        return { startURL, "./" };
> 
> Hm... I would have preferred to have a helper function like you did earlier.

I'm open to adding back a helper function. How does `void defaultScopeURL(const URL& startURL)` sound?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180202/0e7b3702/attachment.html>


More information about the webkit-unassigned mailing list