[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 08:56:55 PST 2018


--- Comment #50 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357091
  --> https://bugs.webkit.org/attachment.cgi?id=357091

View in context: https://bugs.webkit.org/attachment.cgi?id=357091&action=review

>> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:350
>> +    return ResourceResponse::syntheticRedirectResponse(URL([currentRequest URL]), URL([newRequest URL])).nsURLResponse();
> You have a lifetime problem here, the NSURLResponse you are returning is owned by the ResourceResponse returned by syntheticRedirectResponse(), which is a temporary. This is likely the cause of the crash.

I looks to me that synthesizeRedirectResponseIfNecessary() could be updated to return a ResponseResponse type. Looks like there is one call site and it needs a ResponseResponse type.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181212/c65790a6/attachment.html>

More information about the webkit-unassigned mailing list