[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192375

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357091|review?                     |review-
              Flags|                            |

--- Comment #49 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357091
  --> https://bugs.webkit.org/attachment.cgi?id=357091
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357091&action=review

> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:350
> +    return ResourceResponse::syntheticRedirectResponse(URL([currentRequest URL]), URL([newRequest URL])).nsURLResponse();

You have a lifetime problem here, the NSURLResponse you are returning is owned by the ResourceResponse returned by syntheticRedirectResponse(), which is a temporary. This is likely the cause of the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181212/f271b239/attachment.html>