[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 17:24:04 PST 2018


--- Comment #44 from Vivek Seth <v_seth at apple.com> ---
Comment on attachment 357078
  --> https://bugs.webkit.org/attachment.cgi?id=357078

View in context: https://bugs.webkit.org/attachment.cgi?id=357078&action=review

>> Source/WebCore/platform/network/ResourceResponseBase.cpp:128
>> +    redirectResponse.setHTTPVersion("HTTP/1.1"_s);
> Do we really need that one?

I did a 1:1 match of other synthetic redirects that we were doing.

>> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:353
>>      return [[[NSHTTPURLResponse alloc] initWithURL:[currentRequest URL] statusCode:302 HTTPVersion:(NSString *)kCFHTTPVersion1_1 headerFields:synthesizedResponseHeaderFields] autorelease];
> These two lines could be removed.

Good catch! I thought I had removed them.

>> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:356
>> +    return synthesizedResponse.nsURLResponse();
> Could be a one liner, or use auto instead of ResourceResponse.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181212/9aed5b21/attachment.html>

More information about the webkit-unassigned mailing list