[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192375

--- Comment #43 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 357078
  --> https://bugs.webkit.org/attachment.cgi?id=357078
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357078&action=review

> Source/WebCore/platform/network/ResourceResponseBase.cpp:128
> +    redirectResponse.setHTTPVersion("HTTP/1.1"_s);

Do we really need that one?

> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:353
>      return [[[NSHTTPURLResponse alloc] initWithURL:[currentRequest URL] statusCode:302 HTTPVersion:(NSString *)kCFHTTPVersion1_1 headerFields:synthesizedResponseHeaderFields] autorelease];

These two lines could be removed.

> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:356
> +    return synthesizedResponse.nsURLResponse();

Could be a one liner, or use auto instead of ResourceResponse.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181212/c87be7ac/attachment.html>