[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192375

--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
(In reply to youenn fablet from comment #10)
> Comment on attachment 356764 [details]
> Patch
> 
> We are getting very close!
> I am wondering whether we could have a way to write a test for it.

Yes, we've discussed this during one of our meetings and I believe we can write some tests. They will however require some test infrastructure and we are planning to add this later. Note that the code is not even enabled at build time at the moment, AFAIK.

> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356764&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:205
> > +        m_networkLoadChecker->check(ResourceRequest { originalRequest() }, this, requestLoadType, [this] (auto&& result) {
> 
> requestLoadType should probably be set as m_networkLoadChecker creation time
> since it will stay valid for its whole lifetime.
> That way, no need to change check and checkRedirection.
> 
> > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:220
> > +                willSendRedirectedRequest(WTFMove(originalRequestCopy), WTFMove(currentRequest), WTFMove(redirectResponse));
> 
> To remove originalRequestCopy, you can write it:
> willSendRedirectedRequest(ResourceRequest(originalRequestCopy),
> WTFMove(currentRequest), WTFMove(redirectResponse));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181207/2d23a66b/attachment.html>