[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 16:47:44 PST 2018


--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356764
  --> https://bugs.webkit.org/attachment.cgi?id=356764

We are getting very close!
I am wondering whether we could have a way to write a test for it.

View in context: https://bugs.webkit.org/attachment.cgi?id=356764&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:205
> +        m_networkLoadChecker->check(ResourceRequest { originalRequest() }, this, requestLoadType, [this] (auto&& result) {

requestLoadType should probably be set as m_networkLoadChecker creation time since it will stay valid for its whole lifetime.
That way, no need to change check and checkRedirection.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:220
> +                willSendRedirectedRequest(WTFMove(originalRequestCopy), WTFMove(currentRequest), WTFMove(redirectResponse));

To remove originalRequestCopy, you can write it:
willSendRedirectedRequest(ResourceRequest(originalRequestCopy), WTFMove(currentRequest), WTFMove(redirectResponse));

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181207/0582be54/attachment.html>

More information about the webkit-unassigned mailing list