[Webkit-unassigned] [Bug 189114] Long press on picture/link show menu obscured by keyboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189114

--- Comment #3 from James Savage <james.savage at apple.com> ---
Comment on attachment 348447
  --> https://bugs.webkit.org/attachment.cgi?id=348447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348447&action=review

Will come back with a v2. I think moving the free function to an instance method will address your concerns.

>> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:373
>> +        CGRect visibleRect = CGRectNull;
> 
> See associated next comment.
> I think this should be view.window.bounds (or equivalent) not CGRectNull.

I’m trying to keep the fallback value in one place. If you don’t like using CGRectNull as a sentinel, how about moving presentationStyleForView() to an instance method on WKActionSheetAssistant. That way it could make the delegate call and have the fallback, rather than callers providing it?

>> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:414
>> +
> 
> remove whitespace

This was already here (the diff got out of order), but I can remove it.

>> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:549
>> +    CGRect visibleRect = CGRectNull;
> 
> Same as above. Should be view.window.bounds

Ditto also :P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180830/1ce45951/attachment.html>