[Webkit-unassigned] [Bug 171100] Implement the Web Share API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 21:53:09 PDT 2018


--- Comment #12 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347525
  --> https://bugs.webkit.org/attachment.cgi?id=347525

View in context: https://bugs.webkit.org/attachment.cgi?id=347525&action=review

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:101
> +    auto completionHandlerBlock = BlockPtr<void((NSString *activityType, BOOL completed, NSArray *returnedItems, NSError *activityError))>::fromCallable([completionHandler = WTFMove(completionHandler), shareSheet = self](NSString *activityType, BOOL completed, NSArray *returnedItems, NSError *activityError) mutable {

You don’t need to name all the parameters in the BlockPtr type definition (I’m pretty sure).

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:108
> +    [self _presentFullscreenViewController:_shareSheetViewController.get() animated:NO];

We definitely want an animated presentation.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/6aa43748/attachment.html>

More information about the webkit-unassigned mailing list