[Webkit-unassigned] [Bug 171100] Implement the Web Share API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 21:41:50 PDT 2018


--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347525
  --> https://bugs.webkit.org/attachment.cgi?id=347525

View in context: https://bugs.webkit.org/attachment.cgi?id=347525&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4644
> +    _shareSheet = adoptNS([[WKShareSheet alloc] initWithView:self]);

I think most of this logic should be inside WKShareSheet; hand ShareDataWithParsedURL all the way in there and do the conversion to ObjC types there.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4648
> +    if ([data.shareData.title length] > 0)

This is weird, because you’re going from WTFString to NSString just to check the length. WTFString has .isEmpty(), probably better to just use that.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4654
> +    if (data.url.isNull())

I think you meant to have a ! here :P

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/f55f957c/attachment.html>

More information about the webkit-unassigned mailing list