[Webkit-unassigned] [Bug 188460] [CMake] Add ENABLE_UNDEFINED_BEHAVIOR_SANITIZER to make it easier to build with UBSan

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 18 07:35:56 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188460

--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 346878
  --> https://bugs.webkit.org/attachment.cgi?id=346878
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346878&action=review

> Source/cmake/WebKitCompilerFlags.cmake:181
> +        WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-fno-omit-frame-pointer)

Put this inside an if (NOT ENABLE_ADDRESS_SANITIZER) so that we don't add it twice if both sanitizers are enabled. (ubsan is the only sanitizer that doesn't conflict with the other sanitizers. If we add more sanitizers in the future, we need to make sure to fail the build if conflicting sanitizers are enabled.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180818/a6688f81/attachment.html>


More information about the webkit-unassigned mailing list