[Webkit-unassigned] [Bug 188460] [CMake] Add ENABLE_UNDEFINED_BEHAVIOR_SANITIZER to make it easier to build with UBSan

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 18 07:34:40 PDT 2018


--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 346878
  --> https://bugs.webkit.org/attachment.cgi?id=346878

View in context: https://bugs.webkit.org/attachment.cgi?id=346878&action=review

>>> Source/cmake/WebKitCompilerFlags.cmake:185
>>> +        set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fsanitize=undefined")
>> 1. Ideally, when CMAKE_EXE_LINKER_FLAGS and CMAKE_SHARED_LINKER_FLAGS are modified, one should also modify CMAKE_MODULE_LINKER_FLAGS
>> 2. Why not just use ECMEnableSanitizers? [1] At least it makes sense to borrow there ideas, e.g. there must be a reason why they use -fno-optimize-sibling-calls with ubsan as well.
>> [1] https://github.com/KDE/extra-cmake-modules/blob/master/modules/ECMEnableSanitizers.cmake
>> https://api.kde.org/ecm/module/ECMEnableSanitizers.html
> Don, you should of course fix ENABLE_ADDRESS_SANITIZER as well, then.

Still needs CMAKE_MODULE_LINKER_FLAGS (bug #188699)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180818/f892c006/attachment-0001.html>

More information about the webkit-unassigned mailing list