[Webkit-unassigned] [Bug 185045] Add Support for a Download Build Product Script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185045

--- Comment #5 from Amal Hussein <amal at bocoup.com> ---
Comment on attachment 339013
  --> https://bugs.webkit.org/attachment.cgi?id=339013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339013&action=review

>> Tools/Scripts/webkitpy/common/build_binaries_fetcher.py:97
>> +            if self.host.filesystem.exists(self.local_build_binaries_dir):
> 
> Maybe we should add a force option in case something bad happened and we need to overwrite the folder.

yes - thats a good idea - I'll add a force flag which we can use retry logic elsewhere

>> Tools/Scripts/webkitpy/common/build_binaries_fetcher.py:156
>> +            extract_exception = Exception('Cannot extract zipfile %s' % self.local_zip_path)
> 
> Can we do "import zipfile" and use that instead of platform specific code?

The reason why I'm using the platform-specific handling here is to avoid file permission issues I experienced when I did an extraction via zipfile.extract.  I had to use os.chmod to set permissions for the executable files, etc..

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180427/372b9948/attachment.html>