[Webkit-unassigned] [Bug 185045] Add Support for a Download Build Product Script
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 27 12:56:26 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=185045
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #339013|review? |review-
Flags| |
--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339013
--> https://bugs.webkit.org/attachment.cgi?id=339013
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=339013&action=review
This clearly needs to share code with ./Tools/Scripts/bisect-builds. In fact, we have very similarly named script:
Tools/BuildSlaveSupport/download-built-product
I don't think we should land this script as is.
> Tools/Scripts/download-build-product.py:49
> + optparse.make_option('--revision', type='str', default=None,
> + help=('Pass in a build revision number from WebKit archives to download binaries. Revision=None will download the latest build.'))]),
Nit: wrong indentation. We always use 4 spaces, and never align to ( or any other punctuation.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180427/4d3372a7/attachment.html>
More information about the webkit-unassigned
mailing list