[Webkit-unassigned] [Bug 184588] [GStreamer] Fix the way GstStreamCollection is handled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 06:32:03 PDT 2018


--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Philippe Normand from comment #7)
> Comment on attachment 338581 [details]
> [GStreamer] Fix the way GstStreamCollection is handled
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338581&action=review
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-646
> > -                unsigned localIndex = i - validVideoStreams.size() - validTextStreams.size();
> > -                if (localIndex < m_audioTracks.size()) {
> > -                    if (m_audioTracks.contains(streamId))
> > -                        continue;
> Hum, the reason for this was to avoid adding a track that exists already...
> Removing this code might lead to unintended track-added (or something)
> <video> events. Are you sure this patch doesn't break any test?

Right, thing is that now my first step is to remove all tracks previously configure tracks, those track are being obseleted by the new StreamCollection, so they should not be taken in consideration.

I will re run the tests again, do not merge yet.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180423/9a2677dd/attachment.html>

More information about the webkit-unassigned mailing list