[Webkit-unassigned] [Bug 184588] [GStreamer] Fix the way GstStreamCollection is handled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184588

--- Comment #7 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 338581
  --> https://bugs.webkit.org/attachment.cgi?id=338581
[GStreamer] Fix the way GstStreamCollection is handled

View in context: https://bugs.webkit.org/attachment.cgi?id=338581&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-646
> -                unsigned localIndex = i - validVideoStreams.size() - validTextStreams.size();
> -                if (localIndex < m_audioTracks.size()) {
> -                    if (m_audioTracks.contains(streamId))
> -                        continue;

Hum, the reason for this was to avoid adding a track that exists already... Removing this code might lead to unintended track-added (or something) <video> events. Are you sure this patch doesn't break any test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180423/48bdd3df/attachment.html>