[Webkit-unassigned] [Bug 184418] ImageFrame type used by non-Cocoa image decoder should not be the same as that used by ImageSource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184418

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com

--- Comment #12 from Antti Koivisto <koivisto at iki.fi> ---
> I tried very hard to merge both in one class named ImageFrame; see
> <http://trac.webkit.org/changeset/206156>. My goal, which I did not have
> time to do till now, was to have a single cached ImageFrame for all ports
> and remove the second copy which the non-Cocoa image decoder still keep.
> 
> And now, you are making two implementations of ImageFrame again :).

I don't understand why. The types share almost nothing of any relevance. Even the actual image data is kept in m_backingStore in the decoder case and in m_nativeImage in ImageSource case. 

It makes it very difficult to make any changes to BitmapImage code as some platform specific decoder always breaks. I think the refactoring to merge the types was misguided.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180409/98f8f941/attachment-0002.html>