[Webkit-unassigned] [Bug 184418] ImageFrame type used by non-Cocoa image decoder should not be the same as that used by ImageSource

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 10:31:24 PDT 2018


Said Abou-Hallawa <sabouhallawa at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |sabouhallawa at apple.com

--- Comment #11 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
There were two types of the ImageFrame. One was named FrameData, which is used by ImageSource. And the other was named ImageFrame, which was used by the non-Cocoa image decoders.

I tried very hard to merge both in one class named ImageFrame; see <http://trac.webkit.org/changeset/206156>. My goal, which I did not have time to do till now, was to have a single cached ImageFrame for all ports and remove the second copy which the non-Cocoa image decoder still keep.

And now, you are making two implementations of ImageFrame again :).

Can you please reconsider this in your patch? There is no real need to have a second copy with non-Cocoa image decoder. They are almost the same expect the one with non-Cocoa image decoder keeps the pixel data and the NativeImage while the one with the ImageSource keeps the NativeImage only.

If you do not have enough time to do that, I would suggest making ScalableImageDecoderFrame a sub-class of ImageFrame. But PLEASE do not have different implementations for the two classes. This basically roll back what I did and make it difficult to remove the double caching issue.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180409/19a332b8/attachment-0002.html>

More information about the webkit-unassigned mailing list