[Webkit-unassigned] [Bug 177225] Update syncing script to be able to build binary for commit set with owned commits.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 28 01:11:04 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=177225

--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 321808
  --> https://bugs.webkit.org/attachment.cgi?id=321808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321808&action=review

>> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1007
>> +                    'checkbox': {'ifRepositorySet': {'value': 'build-webkit', 'repositoriesToCheck': ['WebKit']}},
> 
> There's no need to have two nested dictionaries like this.
> We should relax the restriction in _parseRepositoryGroupPropertyTemplate that option's dictionary can only contain a single key,
> and specify value & repositoriesToCheck in the outer dictionary as in:
> {'fRepositorySet': ['WebKit'], 'value': 'build-webkit'}

How do we determine which key of this dictionary should be used as first argument of makeOption?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170928/83d8972e/attachment.html>


More information about the webkit-unassigned mailing list