[Webkit-unassigned] [Bug 177477] Web Inspector: Fix Layers tab sidebar popover.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177477

--- Comment #6 from Ross Kirsling <ross.kirsling at sony.com> ---
(In reply to Matt Baker from comment #4)
> FYI:
> <https://webkit.org/b/150551> Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned

Cool. I couldn't find another place in Web Inspector that had a side-facing popover, but I believe this would happen for any such case.

(In reply to Matt Baker from comment #5)
> > Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:-91
> > -        this._dataGrid.element.addEventListener("click", this._dataGridClicked.bind(this), false);
> 
> I'm glad to see all this go. I think eventually we'll want to completely
> rethink the Layers sidebar UI. Putting important data (compositing reasons!)
> in popovers and forcing people to play the popover game is terrible.

That's fair. Just hoping to provide an adequate UX for Day 1 -- I'm not really sure how to fundamentally restructure that information, but at least one can sort by highest-impact layers, even if you have to ask "why" for each one separately.

> > Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:-151
> > -    _highlightSelectedNode()
> 
> I'm not clear on why this is being removed. Calling this when the node
> changes works fine with your other changes, as long as the highlight is
> removed later.

Sure, I can put this back and remove it in the following ticket.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170927/ccf2a678/attachment-0001.html>