[Webkit-unassigned] [Bug 177477] Web Inspector: Fix Layers tab sidebar popover.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177477

--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 321782
  --> https://bugs.webkit.org/attachment.cgi?id=321782
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321782&action=review

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:-91
> -        this._dataGrid.element.addEventListener("click", this._dataGridClicked.bind(this), false);

I'm glad to see all this go. I think eventually we'll want to completely rethink the Layers sidebar UI. Putting important data (compositing reasons!) in popovers and forcing people to play the popover game is terrible.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:-151
> -    _highlightSelectedNode()

I'm not clear on why this is being removed. Calling this when the node changes works fine with your other changes, as long as the highlight is removed later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170927/de0d461f/attachment.html>