[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 25 10:14:37 PDT 2017


--- Comment #58 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 321600
  --> https://bugs.webkit.org/attachment.cgi?id=321600

View in context: https://bugs.webkit.org/attachment.cgi?id=321600&action=review

>>> Source/WebCore/editing/ios/AutofillElements.h:36
>>> +    AutofillElements(RefPtr<HTMLInputElement>, RefPtr<HTMLInputElement>);
>> Use RefPtr<HTMLInputElement>&& instead to avoid ref churn.
> What is 'ref churn'?

This is when objects that keep track of reference counts (e.g. RefPtr, Ref, RetainPtr) are unnecessarily destroyed and recreated. In this case, we can turn this into RefPtr<HTMLInputElement>&&s and WTFMove() at the call site to avoid this extra dance.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170925/a7a40efe/attachment.html>

More information about the webkit-unassigned mailing list