[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #57 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 321600
  --> https://bugs.webkit.org/attachment.cgi?id=321600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321600&action=review

>> Source/WebCore/editing/ios/AutofillElements.h:36
>> +    AutofillElements(RefPtr<HTMLInputElement>, RefPtr<HTMLInputElement>);
> 
> Use RefPtr<HTMLInputElement>&& instead to avoid ref churn.

What is 'ref churn'?

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2816
>> +        auto autofillElements = AutofillElements::computeAutofillElements(assistendElement.get());
> 
> It looks like we don't need this local variable?
> Why not just do this?:
> AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assistedNode));

Done.

>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:37
>> +// FIXME 34583628: Simplyfy this once the UIKit work is available in the build.
> 
> Nit: "FIXME <radar:34583628>: ~"

Done.



Thanks for reviewing, Ryosuke!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170925/ddae97b2/attachment.html>