[Webkit-unassigned] [Bug 176995] [Harfbuzz] Material icons not rendered correctly when using the web font

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176995

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 320891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320891&action=review
> 
> > Source/WebCore/ChangeLog:20
> > +        are ASCII. We should also consider handling other cases mentioned by the spec like brackets and quotation marks,
> > +        but that belongs to a different bug/commit.
> 
> r=me if you file a new bug report.

Sure, I will.

> > Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:379
> > +        if (isASCII(character) && isASCII(previousCharacter))
> 
> Why the isASCII check? Did this fix something? Surely that's not going to
> work for e.g. curly quotation marks.

Just tried to be conservative here. Why do you think curly quotation marks are going to be broken?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170915/7c00b3d3/attachment.html>