[Webkit-unassigned] [Bug 176995] [Harfbuzz] Material icons not rendered correctly when using the web font

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176995

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320891|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 320891
  --> https://bugs.webkit.org/attachment.cgi?id=320891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320891&action=review

> Source/WebCore/ChangeLog:20
> +        are ASCII. We should also consider handling other cases mentioned by the spec like brackets and quotation marks,
> +        but that belongs to a different bug/commit.

r=me if you file a new bug report.

> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:379
> +        if (isASCII(character) && isASCII(previousCharacter))

Why the isASCII check? Did this fix something? Surely that's not going to work for e.g. curly quotation marks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170915/e9d04cb1/attachment-0001.html>