[Webkit-unassigned] [Bug 176436] Add Live PLT implemented with WebDriver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176436

--- Comment #4 from dewei_zhu at apple.com ---
Comment on attachment 319968
  --> https://bugs.webkit.org/attachment.cgi?id=319968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319968&action=review

> Tools/ChangeLog:36
> +        * Scripts/webkitpy/webdriver_plt/suites/__init__.py: Added.

This file should not be empty, otherwise, it will be ignored by svn.

> Tools/Scripts/webkitpy/webdriver_plt/liveplt.py:12
> +    'safari': 76,
> +    'chrome': 0,
> +    'firefox': 37,
> +    'stp': 76,
> +}

Does those number ever change?

> Tools/Scripts/webkitpy/webdriver_plt/pltresults.py:28
> +        self.product *= time

I would prefer using log function to calculate geomean.
geomean = (x * y)^(1/2)
-> log(geomean) = log((x * y)^(1/2))
-> log(geomean) = (1/2) * (log(x) + log(y))
So we can accumulate log(time) here, and get geomean by apply pow(e, accumulated_value / n)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170907/4247580d/attachment.html>