[Webkit-unassigned] [Bug 176436] Add Live PLT implemented with WebDriver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176436

--- Comment #3 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 319968
  --> https://bugs.webkit.org/attachment.cgi?id=319968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319968&action=review

> Tools/Scripts/run-webdriver-plt.py:13
> +    parser.add_argument('-n', '--instances', dest='instances', type=int, default=3, help='Test the suite n times in the same browser session')

This backwards from the other plt.  Instances is number of times safari is launched

> Tools/Scripts/webkitpy/webdriver_plt/liveplt.py:23
> +        self.size = size

I'd create a log message dumping the parameters here.  It's useful to go back and look at the defaults when trying to compare two logs.

> Tools/Scripts/webkitpy/webdriver_plt/liveplt.py:90
> +        sleep(1)

Ideally you'd use web driver to figure out when the window is maximized.  Blanket sleep statements often behave badly when things aren't going as planned.

> Tools/Scripts/webkitpy/webdriver_plt/liveplt.py:116
> +                    pass  # opening new tabs not currently possible

please print a help message here

> Tools/Scripts/webkitpy/webdriver_plt/liveplt.py:133
> +        NT_results = driver.execute_script('return performance.getEntriesByType("navigation")[0]')  # navigation timing 2

nit probably should have used lower case nt.

> Tools/Scripts/webkitpy/webdriver_plt/suites/social.suite:13
> +    ]

pleased add a media suite.  ie. youtube flickr

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170906/a98b5649/attachment.html>