[Webkit-unassigned] [Bug 179068] AX: search predicate returns containing group for plain text instead of text element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179068

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 325472
  --> https://bugs.webkit.org/attachment.cgi?id=325472
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325472&action=review

> LayoutTests/accessibility/mac/search-predicate-plaintext.html:12
> +<p style="color:blue; font-family:serif; font-style:italic;">serif blue italic text</p>

we need to add more cases that would have been found before but now fail to find

> Source/WebCore/accessibility/AccessibilityLabel.h:48
> +    bool canHaveStringValue() const final;

this should return true inline here

> Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:169
> +    if (is<HTMLOptGroupElement>(*m_optionElement))

do these really count as plain text? they're more like controls

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1906
> +    if (ariaRoleAttribute() == AccessibilityRole::StaticText)

which elements are hitting AccessibilityNodeObject instead of AXRenderObject?

> Source/WebCore/accessibility/AccessibilityObject.cpp:221
> +        if (axObject->hasPlainText())

this seems unnecessary

> Source/WebCore/accessibility/AccessibilityObject.h:-594
> -    

undo

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:810
> +    if (is<RenderMenuList>(cssBox))

are menu lists really considered plain text?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:816
> +    if (isWebArea())

we shouldn't have false cases. that should just be the default

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:819
> +    if (isTextControl())

do you have the content editable and role=textbox case covered

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171031/e91442cd/attachment-0001.html>