[Webkit-unassigned] [Bug 179068] AX: search predicate returns containing group for plain text instead of text element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179068

--- Comment #4 from Doug Russell <d_russell at apple.com> ---
(In reply to chris fleizach from comment #3)
> Comment on attachment 325472 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325472&action=review
> 
> > LayoutTests/accessibility/mac/search-predicate-plaintext.html:12
> > +<p style="color:blue; font-family:serif; font-style:italic;">serif blue italic text</p>
> 
> we need to add more cases that would have been found before but now fail to
> find

I have at least one where it would find the group around the second block quote instead of text in it

> 
> > Source/WebCore/accessibility/AccessibilityLabel.h:48
> > +    bool canHaveStringValue() const final;
> 
> this should return true inline here

on it

> 
> > Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:169
> > +    if (is<HTMLOptGroupElement>(*m_optionElement))
> 
> do these really count as plain text? they're more like controls

this check is if it can yield text, not if it's plain text

> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1906
> > +    if (ariaRoleAttribute() == AccessibilityRole::StaticText)
> 
> which elements are hitting AccessibilityNodeObject instead of AXRenderObject?

not sure, but I wanted the implementation to be consistent, I'll see if I can find concrete examples

> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:221
> > +        if (axObject->hasPlainText())
> 
> this seems unnecessary

left over debug code, I'll remove it

> 
> > Source/WebCore/accessibility/AccessibilityObject.h:-594
> > -    
> 
> undo

on it

> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:810
> > +    if (is<RenderMenuList>(cssBox))
> 
> are menu lists really considered plain text?

this is only a check if it can yield text, not if it's plain text

> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:816
> > +    if (isWebArea())
> 
> we shouldn't have false cases. that should just be the default

good point

> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:819
> > +    if (isTextControl())
> 
> do you have the content editable and role=textbox case covered


the isTextControl check covers both of those as AccessibilityRole::TextArea

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171031/a2f05167/attachment.html>