[Webkit-unassigned] [Bug 142673] [GTK] Automatically adjust font size when gtk-xft-dpi changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142673

--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
One more pre-review comment. The EWS bots (the green and red bubbles above) try building your patch to look for problems. I see the GTK bubble is green, which is great, but the WPE bubble is red:

/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: In function 'void webKitSettingsDispose(GObject*)':
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:230:21: warning: unused variable 'settings' [-Wunused-variable]

You'll need to move the declaration down into the #if PLATFORM(GTK) block you added below to avoid this warning for WPE. It's C++ so the code style for declarations is different: you should limit the scope of variables by declaring them only where they're actually required, rather than at the top of functions.

/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: In function 'void webKitSettingsSetProperty(GObject*, guint, const GValue*, GParamSpec*)':
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:309:84: error: 'webkit_settings_set_default_font_size_pts' was not declared in this scope
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:315:94: error: 'webkit_settings_set_default_monospace_font_size_pts' was not declared in this scope
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: In function 'void webKitSettingsGetProperty(GObject*, guint, GValue*, GParamSpec*)':
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:489:83: error: 'webkit_settings_get_default_font_size_pts' was not declared in this scope
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:495:93: error: 'webkit_settings_get_default_monospace_font_size_pts' was not declared in this scope

I forgot to tell you that there are separate WebKitSettings.h files for GTK and WPE, and they have to be updated in tandem. I know that's yucky, but the only alternative is to generate the headers from a common template, and we haven't gone down that road yet. So you'll have to take care of that too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171030/805dc644/attachment.html>