[Webkit-unassigned] [Bug 142673] [GTK] Automatically adjust font size when gtk-xft-dpi changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142673

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Thanks, I'll review it soon.

(In reply to Build Bot from comment #11)
> Attachment 325369 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:906:  When
> wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:908:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:909:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:910:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:911:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:939:  When
> wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:941:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:942:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:943:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> ERROR: Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:944:  Weird
> number of spaces at line-start.  Are you using a 4-space indent? 
> [whitespace/indent] [3]
> WARNING: File exempt from style guide. Skipping:
> "Source/WebKit/UIProcess/API/gtk/WebKitSettings.h"
> Total errors found: 10 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

You'll have to follow WebKit code style for the property declarations too, even if it doesn't match the surrounding code:

    /**
     * WebKitSettings:default-font-size-pts:
     *
     * The default font size in points to use for content displayed if
     * no font size is specified.
     *
     * Since: 2.20
     */
    g_object_class_install_property(
        gObjectClass,
        PROP_DEFAULT_FONT_SIZE_PTS,
        g_param_spec_uint(
            "default-font-size-pts",
            _("Default font size in points"),
            _("The default font size in points used to display text."),
            5, G_MAXUINT, 12,
            readWriteConstructParamFlags));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171030/c222dc3d/attachment.html>