[Webkit-unassigned] [Bug 178720] [GTK][WPE] Switch to use API::NavigationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178720

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324800|review?                     |review+
              Flags|                            |

--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 324800
  --> https://bugs.webkit.org/attachment.cgi?id=324800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324800&action=review

> Source/WebKit/UIProcess/API/APINavigationAction.h:44
> +    static Ref<NavigationAction> create(WebKit::NavigationActionData&& navigationActionData, API::FrameInfo* sourceFrame, std::optional<WTF::String> targetFrameName, WebCore::ResourceRequest&& request, bool shouldOpenAppLinks, RefPtr<UserInitiatedAction>&& userInitiatedAction)

I think we should just have one create function.

> Source/WebKit/UIProcess/API/APINavigationAction.h:85
> +    std::optional<WTF::String> m_targetFrameName;

Could we have a null string meaning there's no frame name instead of an optional string?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171026/aad2ec72/attachment.html>