[Webkit-unassigned] [Bug 178554] Web Inspector: Layer mutations should be purely based on layerId, not based on nodeId

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 21 16:19:35 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=178554

--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
(In reply to Devin Rousso from comment #2)
> > +        * UserInterface/Controllers/LayerTreeManager.js:
> > +        (WI.LayerTreeManager.prototype.layerTreeMutations):
> 
> This could use an explanation as to why this is needed or what the problem
> originally was.

Can do.

> > Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js:-59
> > -            return layer.isGeneratedContent ? layer.pseudoElementId : layer.nodeId;
> 
> Does this patch still work with pseudo-elements?  Adding a test for this
> would be awesome =D
> 
> > Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js:-73
> > -            if (layer.isReflection)
> 
> Is the concept of `isReflection` no longer valid/useful?

Sorry if this wasn't all clear above: It was incorrect to be looking for special cases involving nodeIds at all (as these need not be unique in the layer list). A preserved layer should be nothing more or less than a recycled layerId (the thing that *is* unique). Pseudo-elements were actually the very thing being mishandled on your website, as a result of this special-casing. :) Reflections should follow suit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171021/f2007419/attachment.html>


More information about the webkit-unassigned mailing list