[Webkit-unassigned] [Bug 178554] Web Inspector: Layer mutations should be purely based on layerId, not based on nodeId

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178554

Devin Rousso <webkit at devinrousso.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit at devinrousso.com

--- Comment #2 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 324320
  --> https://bugs.webkit.org/attachment.cgi?id=324320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324320&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        * UserInterface/Controllers/LayerTreeManager.js:
> +        (WI.LayerTreeManager.prototype.layerTreeMutations):

This could use an explanation as to why this is needed or what the problem originally was.

> Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js:-59
> -            return layer.isGeneratedContent ? layer.pseudoElementId : layer.nodeId;

Does this patch still work with pseudo-elements?  Adding a test for this would be awesome =D

> Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js:-73
> -            if (layer.isReflection)

Is the concept of `isReflection` no longer valid/useful?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171021/676fa2d8/attachment.html>