[Webkit-unassigned] [Bug 177279] [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177279

--- Comment #5 from Stephan Szabo <stephan.szabo at sony.com> ---
> > Source/JavaScriptCore/shell/PlatformJSCOnly.cmake:3
> > +    add_definitions(-DWIN_CAIRO)
> Is this necessary? JSCOnly port is not relying on Cairo.

Right now shell/DLLLauncherMain.cpp checks for WIN_CAIRO in places to separate it from applewin, for example 
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/shell/DLLLauncherMain.cpp#L125
where the library path added differs. And we're currently really only handling the wincairo paths in jsc-only, but that might change.

That file's related to the tiny launcher app mentioned in the below.

> Why can't we do the same to the other non-Windows port (and removing  PlatformWin.cmake)?
> Is there any specific issues for Windows port?

I'm not sure of the history, but the shell, testapi, etc on Windows (non-jsc-only) build a separate <something>Lib.dll and then a small launcher to run the code from the dll. The description from when the launcher seemed to be added seemed like it was related to getting the apple support libraries for the testapi and similar apps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171011/3b12be14/attachment.html>