[Webkit-unassigned] [Bug 177279] [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 10:27:18 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=177279

--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 321487
  --> https://bugs.webkit.org/attachment.cgi?id=321487
Build jsc/testapi/testmasm on windows jsc-only similar to win platform

View in context: https://bugs.webkit.org/attachment.cgi?id=321487&action=review

Making JSC tests work in Windows (in JSCOnly port) is great. I have several questions.

> Source/JavaScriptCore/shell/PlatformJSCOnly.cmake:3
> +    add_definitions(-DWIN_CAIRO)

Is this necessary? JSCOnly port is not relying on Cairo.

> Source/JavaScriptCore/shell/PlatformJSCOnly.cmake:4
> +endif ()

Why can't we do the same to the other non-Windows port (and removing PlatformWin.cmake)?
Is there any specific issues for Windows port?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171011/4b25ef5d/attachment.html>


More information about the webkit-unassigned mailing list