[Webkit-unassigned] [Bug 178065] Add an option to show raw numbers of run-benchmark results.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178065

--- Comment #11 from dewei_zhu at apple.com ---
Comment on attachment 323159
  --> https://bugs.webkit.org/attachment.cgi?id=323159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323159&action=review

>> Tools/ChangeLog:9
>> +        Adding '--show-raw-values' option allows showing raw numbers for run-benchmark results.
> 
> Why don't we make this the default option??

Showing the raw number may end up with a very long line in output, I'm not sure whether all the user want to see that. Also using '--read-results-json' with '--show-raw-values' can 'replay' the numbers.

>> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:81
>> +                            formated_value_str = ', '.join(map('{:.3f}'.format, values))
> 
> I guess we don't want to show decimal points if they're whole number?

OK, I can add a check which uses value.is_integer() to determine the way to format the number.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171010/33376a66/attachment.html>