[Webkit-unassigned] [Bug 178065] Add an option to show raw numbers of run-benchmark results.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178065

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323159|review?                     |review-
              Flags|                            |

--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 323159
  --> https://bugs.webkit.org/attachment.cgi?id=323159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323159&action=review

We need unit tests for this.

> Tools/ChangeLog:9
> +        Adding '--show-raw-values' option allows showing raw numbers for run-benchmark results.

Why don't we make this the default option??

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:81
> +                        if is_a_list_of_int:
> +                            formated_value_str = ', '.join(map(str, values))
> +                        else:
> +                            formated_value_str = ', '.join(map('{:.3f}'.format, values))

I guess we don't want to show decimal points if they're whole number?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171010/67036b3c/attachment-0001.html>