[Webkit-unassigned] [Bug 177932] [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177932

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327360|review?                     |review+
              Flags|                            |

--- Comment #27 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 327360
  --> https://bugs.webkit.org/attachment.cgi?id=327360
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=327360&action=review

> Source/WebCore/platform/network/soup/CookieSoup.cpp:39
> +    , expires(0)

Would it be possible to initialize this here?

, expires(cookie->expires ? static_cast<double>(soup_date_to_time_t(cookie->expires)) * 1000 : 0)

> Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:350
> + * Returns: (element-type SoupCookie) (transfer full): A #GSList of #SoupCookie instances.

It's not a GSList, but a GList. Even if transfer full is used, I would still clarify that user should free the list and its contents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171120/5770580d/attachment.html>