[Webkit-unassigned] [Bug 177932] [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 20 14:00:27 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=177932

--- Comment #28 from Mario Sanchez Prada <mario at webkit.org> ---
(In reply to Carlos Garcia Campos from comment #27)
> Comment on attachment 327360 [details]
> Patch proposal
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327360&action=review
> 
> > Source/WebCore/platform/network/soup/CookieSoup.cpp:39
> > +    , expires(0)
> 
> Would it be possible to initialize this here?
> 
> , expires(cookie->expires ?
> static_cast<double>(soup_date_to_time_t(cookie->expires)) * 1000 : 0)

Sure, actually that was my first approach but I changed it because I was unsure that was the right style. Will change it back before landing.

> > Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:350
> > + * Returns: (element-type SoupCookie) (transfer full): A #GSList of #SoupCookie instances.
> 
> It's not a GSList, but a GList. Even if transfer full is used, I would still
> clarify that user should free the list and its contents.

Right, I'll fix that too before landing too.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171120/f9620823/attachment-0001.html>


More information about the webkit-unassigned mailing list