[Webkit-unassigned] [Bug 179416] Remove support for iOS-only softbank-sjis encoding if possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179416

--- Comment #3 from Darin Adler <darin at apple.com> ---
(In reply to Maciej Stachowiak from comment #2)
> But that will result in a TextCodecICU with a null m_canonicalConverterName,
> which will therefore always fail to create the ICU converter, because it
> will pass null to ucnv_open.

I think you are right that it doesn’t work.

>From my reading of the code, it won’t fail, but also won’t do anything useful. From the ucnv_open documentation:

"If this parameter is NULL, the default converter will be used."

So it will create ICU's "default converter", whatever that is; reading the documentation doesn’t really make it all that clear to me what it is, although it can be changed with ucnv_setDefaultName.

And also, it seems that TextCodecICU::createICUConverter will crash with a null dereference calling strcmp, if this is tried again after the converter is cached.

So, in summary, should almost certainly remove, highly like it does not do anything useful!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171108/051cdd46/attachment.html>