[Webkit-unassigned] [Bug 179416] Remove support for iOS-only softbank-sjis encoding if possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179416

--- Comment #2 from Maciej Stachowiak <mjs at apple.com> ---
By my reading of the code, it seems like the softbank-sjis text codec can't possibly actually work, which might be evidence that it's actually not needed.

The code looks like this:

#if PLATFORM(IOS)
    // See comment above in registerEncodingNames().
    int32_t i = 0;
    for (const char* alias = textCodecMacAliases[i]; alias; alias = textCodecMacAliases[++i])
        registrar(alias, create, 0);
#endif

But that will result in a TextCodecICU with a null m_canonicalConverterName, which will therefore always fail to create the ICU converter, because it will pass null to ucnv_open.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171108/4b30b060/attachment.html>