[Webkit-unassigned] [Bug 172687] Can't use Object.defineProperty() to add an item to a DOMStringMap or Storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172687

--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Ok, my build finished. So I think this is probably as simple as implanting the specced behavior. It is weird though that we're not seeing the defineOwnProperty. Perhaps it has to do with how getOwnPropertySlot is written:

```
bool JSDOMStringMap::getOwnPropertySlot(JSObject* object, ExecState* state, PropertyName propertyName, PropertySlot& slot)
{
    auto* thisObject = jsCast<JSDOMStringMap*>(object);
    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
    if (thisObject->classInfo() == info() && !propertyName.isSymbol()) {
        auto item = thisObject->wrapped().namedItem(propertyNameToAtomicString(propertyName));
        if (!IDLDOMString::isNullValue(item)) {
            slot.setValue(thisObject, 0, toJS<IDLDOMString>(*state, item));
            return true;
        }
    }
    if (Base::getOwnPropertySlot(thisObject, state, propertyName, slot))
        return true;
    return false;
}
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170531/fc5e447f/attachment-0001.html>