[Webkit-unassigned] [Bug 172687] Can't use Object.defineProperty() to add an item to a DOMStringMap or Storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172687

--- Comment #2 from Saam Barati <sbarati at apple.com> ---
(In reply to Sam Weinig from comment #1)
> I believe what we need to do is override the 'defineOwnProperty' static
> function, in addition to 'put' and 'putByIndex'.
> 
> I'd be interested in going over all the overrides we do at some point, as I
> am not 100% what the ramifications of not overriding some (specifically
> getOwnNonIndexPropertyNames, getPropertyNames, getEnumerableLength,
> getStructurePropertyNames, getGenericPropertyNames, preventExtensions, and
> isExtensible) are with respect to the WebIDL specification of 'legacy
> platform objects'
> (https://heycam.github.io/webidl/#es-legacy-platform-objects)

Sam, what does the element derive from here? (I think JSDOMStringMap is a derived source and I don't have a build handy.) Anyways, it seems like it's probably easy to implement the "legacy platform object" semantics you linked to. It is a bit surprising that the element is totally unchanged here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170531/c925b086/attachment-0001.html>